Decompile tt_003 UpdateServantDefault #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeeynamo
approved these changes
Nov 28, 2024
Co-authored-by: Luciano Ciccariello <Xeeynamo@users.noreply.github.com>
|
I agree with the comment. I’ll get a lot of these when I go over the code on one of the refactor passes. I did commit your suggestion though. |
sozud
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function had a lot of the static variables so there is a lot of symbol stuff going on. Also starting to define the entityid enum.
The only thing that is really wonky about this is the g_Events nonsense starting at line 477. It's using the NULL_EVENT in the events array as a ranked lookup, but that's definitely not what should be done. But I think this is dead code that is/was used by the N demon only. Possibly there is some data in the N demon bin that will go where the g_Events goes in this bin, but that may need to be revisited when that bin gets decomped.
match on both.
psx: https://decomp.me/scratch/wMx7M
psp: https://decomp.me/scratch/7mm5D