-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-Request] Generation of the .cbz file from the images #28
Comments
Yep, I'm planning on making |
Make sure the cbz has NO compression. That's the most common error I've found. (you don't want to compress jpgs, and it slows down opening the file greatly. |
oh, thanks for the pointer. Will keep in mind (Y) |
This should work now. Check on your ends please :) |
https://stackoverflow.com/questions/15750429/use-shutil-make-archive-with-zipfile-zip-stored https://docs.python.org/2/library/zipfile.html#zipfile-objects is the better choice, and would allow using ZIP_STORED (no compression) |
I didn't go with the For now, please bear with the shutil, in near future I'll update this with the zipfile and remove the compression, as mentioned in those links. I hope that's fine. :) |
Of course. Any zip is better than no zip. :) I just figured I'd point that out. If someone has issues with the zip file generated, try rezipping to an uncompressed (stored) one, and compare speed/performance. Thank you for all you do, don't mean to see ungrateful. |
Similar to issue #17 it would be nice if we were able to produce .cbz files from directly within the program.
If you dont know these are .zip files containing jpg files. So it should be possible to zip up the images and rename the file to create these.
The text was updated successfully, but these errors were encountered: