Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-Request] Generation of the .cbz file from the images #28

Closed
jaxxa opened this issue Jun 23, 2017 · 7 comments
Closed

[Feature-Request] Generation of the .cbz file from the images #28

jaxxa opened this issue Jun 23, 2017 · 7 comments
Assignees

Comments

@jaxxa
Copy link

jaxxa commented Jun 23, 2017

Similar to issue #17 it would be nice if we were able to produce .cbz files from directly within the program.

If you dont know these are .zip files containing jpg files. So it should be possible to zip up the images and rename the file to create these.

@Xonshiz
Copy link
Owner

Xonshiz commented Jun 23, 2017

Yep, I'm planning on making .epub as well. Since @RamolaWeb mentioned that he'd like to help in getting those PDFs, I'll be leaving that to him. I'll try to get this feature by this weekend.

@sethcohn
Copy link

sethcohn commented Jul 3, 2017

Make sure the cbz has NO compression. That's the most common error I've found. (you don't want to compress jpgs, and it slows down opening the file greatly.

@Xonshiz
Copy link
Owner

Xonshiz commented Jul 3, 2017

oh, thanks for the pointer. Will keep in mind (Y)

@Xonshiz Xonshiz self-assigned this Jul 5, 2017
Xonshiz added a commit that referenced this issue Aug 24, 2017
Fix for #28 .Check the ReadMe for details
@Xonshiz
Copy link
Owner

Xonshiz commented Aug 24, 2017

This should work now. Check on your ends please :)

@Xonshiz Xonshiz closed this as completed Aug 24, 2017
@sethcohn
Copy link

https://stackoverflow.com/questions/15750429/use-shutil-make-archive-with-zipfile-zip-stored
Using plain make archive zip means that compression is used. (which is a mistake for comic archives, and causes big delays in many readers)

https://docs.python.org/2/library/zipfile.html#zipfile-objects is the better choice, and would allow using ZIP_STORED (no compression)

@Xonshiz
Copy link
Owner

Xonshiz commented Aug 24, 2017

I didn't go with the zipfile becasue it didn't have the feature of adding multiple files at once in a compression module. shutil had it. I'll have to iterate over each and every image and then add it in a zip.

For now, please bear with the shutil, in near future I'll update this with the zipfile and remove the compression, as mentioned in those links. I hope that's fine. :)

@sethcohn
Copy link

Of course. Any zip is better than no zip. :) I just figured I'd point that out. If someone has issues with the zip file generated, try rezipping to an uncompressed (stored) one, and compare speed/performance.

Thank you for all you do, don't mean to see ungrateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants