Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 client on HIDPI screens #13

Closed
totaam opened this issue Sep 9, 2019 · 10 comments
Closed

HTML5 client on HIDPI screens #13

totaam opened this issue Sep 9, 2019 · 10 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 9, 2019

Issue migrated from trac ticket # 2410

component: html5 | priority: minor

2019-09-09 14:48:39: sali.andrew created the issue


Hi,

I wanted to ask if there are plans to support HiDPI (e.g. Retina) screens for HTML 5 clients. Out of the box the HTML 5 client will use the css width / height properties to render the server screen, which will result in relatively low resolution displays (the virtualized screen resolution is small).

With some small changes we managed to get around this by using the window.devicePixelRatio to render a higher res screen on the server and scale it back via css transform to the original screen (plus some small changes on the mouse handling). After this the screens look nice and sharp on Retina displays as well.

Would such a patch be considered for inclusion in the repository? Many screens these days tend to have HIDPI resolutions, so some kind of better support might be welcomed by the community.

Many thanks for your great work on this project,

Regards,

Andras

@totaam
Copy link
Collaborator Author

totaam commented Sep 9, 2019

Would such a patch be considered for inclusion in the repository?

Sure, that would be great, please send your version of the changes.
Normally, this should not require any server-side changes.
I don't have any hardware to test it, but I think there are ways to force enable hidpi.

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2019

Probably too late for v3.
See also Xpra-org/xpra#2369, Xpra-org/xpra#1933, Xpra-org/xpra#2500.

@totaam
Copy link
Collaborator Author

totaam commented Mar 18, 2020

Easy enough to reproduce with any browser by scaling up.
@sali.andrew: time to get your code merged, or things will diverge and we'll all end up wasting time.

@totaam
Copy link
Collaborator Author

totaam commented Oct 4, 2020

@sali.andrew: bump!

@totaam
Copy link
Collaborator Author

totaam commented Dec 28, 2020

Not heard back, so it looks like I will have to duplicate the efforts..

@ShadowJonathan
Copy link

I'm encountering this issue after switching to xpra-html5 (as the macos version just had too many bugs), where the canvas on my scaled display becomes fuzzy.

@totaam
Copy link
Collaborator Author

totaam commented Jan 14, 2023

as the macos version just had too many bugs

@ShadowJonathan What specific bugs?
Those are more likely to get fixed than an xpra-html5 issue that I cannot test for lack of hardware.

@ShadowJonathan
Copy link

What specific bugs?

I'll have to get back to you on that at a later point, i'll make a todo item to file them.

@totaam
Copy link
Collaborator Author

totaam commented Jul 3, 2024

Not heard back.

@totaam totaam closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
@ShadowJonathan
Copy link

Apologies, though I haven't encountered this bug again on html5, though macOS native scaling was off/odd since a second ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants