Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32 client 1.0 r13637 disconnects when Session Info is opened, with opengl enabled #1301

Closed
totaam opened this issue Sep 9, 2016 · 11 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 9, 2016

Issue migrated from trac ticket # 1301

component: client | priority: major | resolution: fixed

2016-09-09 19:30:47: afarr created the issue


Testing with win32 1.0 13637 client against a 1.0 13641 fedora 23 server, when opening the Session Info (either with the shift-alt-F11 keyboard shortcut or the tray option) the client disconnects with the following traceback (posting the traceback, the full error message was long so I'll also attach as a separate file).

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 301, in _write_format_thread_loop
    self._add_packet_to_queue(*gpc())
  File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 313, in _add_packet_to_queue
    chunks = self.encode(packet)
  File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 530, in encode
    main_packet, proto_flags = self._encoder(packet)
  File "/usr/lib64/python2.7/site-packages/xpra/net/packet_encoding.py", line 89, in do_rencode
    return  rencode_dumps(data), FLAGS_RENCODE
  File "/rencode/rencode.pyx", line 334, in rencode._rencode.dumps (rencode/rencode.c:4720)
  File "/rencode/rencode.pyx", line 314, in rencode._rencode.encode (rencode/rencode.c:4508)
  File "/rencode/rencode.pyx", line 247, in rencode._rencode.encode_list (rencode/rencode.c:3321)
  File "/rencode/rencode.pyx", line 317, in rencode._rencode.encode (rencode/rencode.c:4541)
  File "/rencode/rencode.pyx", line 264, in rencode._rencode.encode_dict (rencode/rencode.c:3826)
  File "/rencode/rencode.pyx", line 317, in rencode._rencode.encode (rencode/rencode.c:4541)
  File "/rencode/rencode.pyx", line 259, in rencode._rencode.encode_dict (rencode/rencode.c:3650)
  File "/rencode/rencode.pyx", line 317, in rencode._rencode.encode (rencode/rencode.c:4541)
  File "/rencode/rencode.pyx", line 264, in rencode._rencode.encode_dict (rencode/rencode.c:3826)
  File "/rencode/rencode.pyx", line 317, in rencode._rencode.encode (rencode/rencode.c:4541)
  File "/rencode/rencode.pyx", line 259, in rencode._rencode.encode_dict (rencode/rencode.c:3650)
  File "/rencode/rencode.pyx", line 317, in rencode._rencode.encode (rencode/rencode.c:4541)
  File "/rencode/rencode.pyx", line 258, in rencode._rencode.encode_dict (rencode/rencode.c:3639)
  File "/rencode/rencode.pyx", line 320, in rencode._rencode.encode (rencode/rencode.c:4575)
Exception: type <type 'xpra.server.window.region.rectangle'> not handled

Checking with 1.0 r13520 win32 client the Session Info opens as expected (with or without opengl enabled).

Double checking the 13637 win32 client without using the --opengl=on flag (to get around my Intel driver), I also see no errors. Not sure if this is an Intel issue, but I think maxmylyn ran across the same thing with Nvidia.

@totaam
Copy link
Collaborator Author

totaam commented Sep 9, 2016

2016-09-09 19:34:56: afarr uploaded file ticket1301-server-error-message_on-client-session-info-request.txt (95.3 KiB)

full server-side error message

@totaam
Copy link
Collaborator Author

totaam commented Sep 9, 2016

2016-09-09 19:53:16: afarr commented


Additional note - while poking around osx client issues reported in #1302, I began seeing this behavior in the osx 1.0 13637 client as well, but irregularly (maybe the third time I tried to open a Session Info window), and I was seeing it on the osx client whether I forced the opengl=on or not.

Ohh, and when the osx client disconnects, it is also hanging, requiring a force quit.

@totaam
Copy link
Collaborator Author

totaam commented Sep 10, 2016

2016-09-10 04:21:37: antoine changed owner from antoine to afarr

@totaam
Copy link
Collaborator Author

totaam commented Sep 10, 2016

2016-09-10 04:21:37: antoine commented


This was caused by r13639 (debugging of video regions, see #967#comment:27) and is fixed in r13642 + r13643.


Ohh, and when the osx client disconnects, it is also hanging, requiring a force quit.
[[BR]]
Is this related? Does it occur if you don't use session info?. If not, please file a separate ticket.

@totaam
Copy link
Collaborator Author

totaam commented Sep 12, 2016

2016-09-12 20:12:09: afarr commented


D'oh - downloaded win32 1.0 r13644 client, but something must've gone awry in the build, because I can't install (windows 8.1 keeps prompting me to search for an app to open it).

(The osx client disconnection hanging seemed to only be happening with Session Info opening triggered disconnections, by the way... but the new osx client build seems to have gone similarly awry. I'll double check when I'm testing for #1302 to be sure though.)

@totaam
Copy link
Collaborator Author

totaam commented Sep 12, 2016

2016-09-12 20:24:38: antoine commented


I've posted new builds and included both the EXE and ZIP version.
Also, can't you make your own builds?

@totaam
Copy link
Collaborator Author

totaam commented Sep 12, 2016

2016-09-12 23:47:56: afarr changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Sep 12, 2016

2016-09-12 23:47:56: afarr set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Sep 12, 2016

2016-09-12 23:47:56: afarr commented


Huh, didn't even think to look for a .zip version.

The .exe you posted is not installing though. Trying with the .zip, it took so long to connect that I thought it wasn't going to work, but in the end it did connect and I was able to open Session Info without any problems.

Closing.

(And no, I can't make my own win32 client builds, but I can ask Smo nicely. Not sure the state of his build system currently, but I'll ask him double-plus nicely and see what happens.)

@totaam totaam closed this as completed Sep 12, 2016
@totaam
Copy link
Collaborator Author

totaam commented Sep 13, 2016

2016-09-13 05:09:45: antoine commented


I have tried the latest EXE as well as a few more older revisions, on winxp, win7 and win8.1. Works fine every time, so my guess is that you're doing something different.
When did the problem start? Did you verify that it isn't a problem on your system by installing a known "good" version? What build revision is the first one to fail? etc..

@totaam
Copy link
Collaborator Author

totaam commented Sep 13, 2016

2016-09-13 19:08:22: afarr commented


Maybe I was just having issues with my downloading yesterday?

Just downloaded a new copy of 1.0 r13673 and launched, no problems. (I had been able to install previously downloaded builds, just not the ones downloaded yesterday.)

I'd close this again if I could, as is, I'll just scratch my head over what happened and move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant