Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Shadow geometry #3384

Closed
JohelEGP opened this issue Dec 12, 2021 · 2 comments
Closed

SSH Shadow geometry #3384

JohelEGP opened this issue Dec 12, 2021 · 2 comments
Labels
enhancement New feature or request shadow

Comments

@JohelEGP
Copy link

Greetings.

Thank you for this great software.

As a follow up of #3320, running xpra shadow ssh:server:port:display,geometry-option does not handle geometry options just like local displays.

It'd like to use geometry options with a server through SSH.

Since geometry options are part of the CONNECTIONSTRING, it seems they have no place in config files. I did try setting a geometry=500x300 option, to no avail.

Thanks for your attention.

@JohelEGP JohelEGP added the enhancement New feature or request label Dec 12, 2021
totaam added a commit that referenced this issue Apr 26, 2022
but ignore them when matching socket paths
@totaam totaam added the shadow label Apr 26, 2022
@totaam
Copy link
Collaborator

totaam commented Apr 26, 2022

First of all, the syntax you are using is well out of date, please use this form with the commit above - which works-for-me(tm):

xpra shadow ssh://server:sshport/DISPLAY?geometry=1024x640@0x0

Which at least stands a chance of getting parsed correctly in the future.

The geometry options are part of the display string, which got overloaded over time.. so the fix above is really quite ugly.
Unfortunately there is no way to make this backwards compatible either, as the client cannot know in advance if the server supports the new syntax.
The whole thing is likely to change as we may need a more generic solution for #3476.
(so this may break again before the 4.4 release)

See also #3599

@totaam totaam closed this as completed Apr 26, 2022
@JohelEGP
Copy link
Author

JohelEGP commented Apr 19, 2023

Thank you. Now it works with:

xpra shadow ssh://server:sshport/DISPLAY?geometry=1024x640@0x0

So without : before DISPLAY, and with a ? instead of , before geometry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shadow
Projects
None yet
Development

No branches or pull requests

2 participants