Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll the pointer location: make xeyes work #4318

Closed
totaam opened this issue Aug 9, 2024 · 2 comments
Closed

poll the pointer location: make xeyes work #4318

totaam opened this issue Aug 9, 2024 · 2 comments
Labels
client enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Aug 9, 2024

Some applications may use the pointer position, not just for toys like xeyes.
ie: they can use the position to place their windows or tooltips near the pointer.

This is unlikely to ever work under Wayland - "because security" (..)

Since this does expose the pointer location at all times, this should be an option, disabled by default.

@totaam totaam added enhancement New feature or request client labels Aug 9, 2024
@totaam
Copy link
Collaborator Author

totaam commented Aug 9, 2024

Done in the commit above.

Usage:

XPRA_POLL_POINTER=100 xpra attach

The polling delay is in milliseconds - 100 is a good compromise.
(no packets are sent to the server if the position has not changed, and as before only the latest pointer position is sent if the queue is busy)

@totaam totaam closed this as completed Aug 9, 2024
totaam added a commit that referenced this issue Aug 10, 2024
'get_mouse_position()' is only used for sending coordinates to the server, so we have to use the 'client-to-server' coordinate scaling methods
@totaam
Copy link
Collaborator Author

totaam commented Aug 10, 2024

Needed a bit more testing with desktop scaling: cccb97d
(this fix should cause other problems.. hopefully)

totaam added a commit that referenced this issue Aug 11, 2024
'get_mouse_position()' is only used for sending coordinates to the server, so we have to use the 'client-to-server' coordinate scaling methods
totaam added a commit that referenced this issue Aug 11, 2024
sending 'pointer-position' packets before the connection is accepted causes server 'invalid or unknown' packet warnings
totaam added a commit that referenced this issue Aug 12, 2024
totaam added a commit that referenced this issue Sep 23, 2024
totaam added a commit that referenced this issue Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant