Use Android library for settings activity #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chrgernoe
commented
Feb 6, 2024
chrgernoe
commented
- Fixes Use Android Preference Library for App Settings #429
- Fixes Replace Choose-color-buttons in Preferences with pre-defined color wheel #421
Use external library for lead and follow colorization.
chrgernoe
force-pushed
the
feature/429-use-android-preference-library-for-app-settings
branch
from
b1f1ace to
51f09d7
Compare
paetz
previously approved these changes
Feb 20, 2024
| for (stringResource in listOf(R.string.lead, R.string.follow)) { | ||
| findPreference<ColorPickerPreference>(getString(stringResource))?.getColorPickerView()?.let { view -> | ||
| context?.let { context -> | ||
| view.getSharedPreferenceManager().setSharedPreferences( |
There was a problem hiding this comment.
Is view.getSharedPreferenceManager the same object as preferenceManager?
There was a problem hiding this comment.
No. The object preferenceManager (defined in Android library) is the preference manager for the settings in our app and the object that is returned by view.getSharedPreferenceManager is of type ColorPickerPreferenceManager. This is a child of the class defined in the Android library but defined inside the external library.
app/src/main/java/com/yacgroup/yacguide/extensions/ColorPickerPreferenceManager.kt
Show resolved
Hide resolved
paetz
approved these changes
Mar 5, 2024
chrgernoe
deleted the
feature/429-use-android-preference-library-for-app-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.