Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is it possible to avoid bouncing ? #3

Closed
AndroidDeveloperLB opened this issue Jan 25, 2016 · 10 comments
Closed

Question: is it possible to avoid bouncing ? #3

AndroidDeveloperLB opened this issue Jan 25, 2016 · 10 comments
Assignees

Comments

@AndroidDeveloperLB
Copy link

if I move the rectangle outside of the bitmap, it sends me back to where I was.

Is it possible to avoid this, and instead have one of these behaviors:

  1. just stay there, and crop what's shown.
  2. send me to the nearest place that's ok.

The reason is that it's very hard, for example, to crop the image including the edges.
Same goes for when the image is rotated.

@shliama
Copy link
Contributor

shliama commented Jan 25, 2016

Our desired behavior is "send me to the nearest place that's ok".
I'm aware of the issue and trying to find a solution at the moment :octocat:

@shliama shliama self-assigned this Jan 25, 2016
@AndroidDeveloperLB
Copy link
Author

@shliama It would be great to be able to have the choice of what to use.
Also, thank you for this cool library.

@CeccoCQ
Copy link

CeccoCQ commented Jan 29, 2016

+1

@shliama
Copy link
Contributor

shliama commented Feb 1, 2016

Please check version 1.2.0, above issue must be fixed. I've updated core logic so an image must correct its position smoothly and obviously.

@AndroidDeveloperLB
Copy link
Author

@shliama Seems to work perfectly.

@AndroidDeveloperLB
Copy link
Author

Will you also consider the other solution?

@shliama
Copy link
Contributor

shliama commented Feb 3, 2016

No, current behavior is by design. Image cannot be cropped if it does not fill the cropping bounds - so it must be forced to fill em.

@shliama shliama closed this as completed Feb 3, 2016
@AndroidDeveloperLB
Copy link
Author

@shliama Well, we could choose which color/background to use for the parts that are not of the cropped area of the bitmap.

@shliama
Copy link
Contributor

shliama commented Feb 3, 2016

This is how our UCropActivity works. But it's not final - so you are able to extend it and create any behaviour you want.

@AndroidDeveloperLB
Copy link
Author

@shliama Maybe some day. Currently I'm quite busy. Sorry and thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants