Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add round profile to crop. #2

Closed
wants to merge 2 commits into from
Closed

Add round profile to crop. #2

wants to merge 2 commits into from

Conversation

hearsilent
Copy link
Contributor

No description provided.

@loeschg
Copy link

loeschg commented Jan 24, 2016

Would love to have an oval cropping style!

@Rainer-Lang
Copy link

+1

@shliama
Copy link
Contributor

shliama commented Jan 25, 2016

Yes, round & oval cropping style option will be added soon.

But I cannot accept this pull request, because:

  1. It has huge performance issues. You call drawRoundProfile() method for each frame drawn which in turn does tremendous amount of work (e.g. allocating memory for new objects). Please check out this video: https://www.youtube.com/watch?v=HAK5acHQ53E
  2. Furthermore the result of what you try to accomplish doesn't look correct too.

Stay tuned for updates 📻

@shliama shliama closed this Jan 25, 2016
@hearsilent
Copy link
Contributor Author

@shliama

Thanks for your suggestion.

  1. I had commit code to fix it.
  2. This pull request only show round profile preview for what apps wants show both round photo & rectangle photo, that can improve user who want to know if his photo round crop.

hearsilent@032e14a

If you think this commit is ok, I will open pull request again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants