Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjusted multiple directory option #1335 #1336

Merged
merged 4 commits into from
May 2, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Adjusted multiple directory option.

@hitenkoku hitenkoku added the enhancement New feature or request label May 2, 2024
@hitenkoku hitenkoku self-assigned this May 2, 2024
@hitenkoku hitenkoku linked an issue May 2, 2024 that may be closed by this pull request
@hitenkoku hitenkoku added this to the v2.16.0 milestone May 2, 2024
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed following command result has no diff! LGTM!!🚀

% ./hayabusa csv-timeline -w -d ../hayabusa-sample-evtx/DeepBlueCLI -d ../hayabusa-sample-evtx/EVTX-ATTACK-SAMPLES -d ../hayabusa-sample-evtx/EVTX-to-MITRE-Attack -d ../hayabusa-sample-evtx/YamatoSecurity -o new.csv
% ./hayabusa csv-timeline -w -d ../hayabusa-sample-evtx/ -o old.csv
% cat new.csv | sort > sorted-new.csv
% cat old.csv | sort > sorted-old.csv
% diff sorted-new.csv sorted-old.csv
%

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 48fa7e0 into main May 2, 2024
5 checks passed
@YamatoSecurity YamatoSecurity deleted the 1335-allow-d-to-be-specified-multiple-times branch May 2, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow -d to be specified multiple times
3 participants