-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled low memory mode by default #1365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that it works :) LGTM!!🚀
hayabusa-sample-evtx
% ./hayabusa-2.16.0-mac-aarch64 csv-timeline -d ../hayabusa-sample-evtx -D -n -u -q -w -o old.csv --debug
% ./hayabusa-low-memory csv-timeline -d ../hayabusa-sample-evtx -D -n -u -q -w -o new.csv --debug -s
% diff old.csv new.csv
all-evtx
2.16.0
% ./hayabusa-2.16.0-mac-aarch64 csv-timeline -d ../all-evtx -D -n -u -q -w -o old-big.csv --debug
Rule Parse Processing Time: 00:00:01.799
Analysis Processing Time: 00:08:03.302
Output Processing Time: 00:01:58.302
Memory usage stats:
heap stats: peak total freed current unit count
reserved: 16.0 GiB 17.1 GiB 1.1 GiB 16.0 GiB
This PR
% ./hayabusa-low-memory csv-timeline -d ../all-evtx -D -n -u -q -w --debug -o new-big.csv
...
Rule Parse Processing Time: 00:00:01.911
Analysis Processing Time: 00:08:57.270
Output Processing Time: 00:00:00.112
Memory usage stats:
heap stats: peak total freed current unit count
reserved: 5.2 GiB 5.3 GiB 384.0 MiB 5.0 GiB
Unrelated to this PR, but since memory usage has increased since low-memory was released, I will look into this as a separate issue. (In version 2.13.0, memory usage was 2 GB as shown below🤔) I created an issue for the investigation. |
@hitenkoku Thank you! When low memory mode in enabled, we shouldn't be able to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku LGTM! Sorry, I figured out the bug, requires = "sort-events"
needed to be requires = "sort_events"
so I just updated it.
What Changed
I would appreciate it if you could check it out when you have time