Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.0.0 dev build #1517

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Update to 3.0.0 dev build #1517

merged 4 commits into from
Nov 30, 2024

Conversation

YamatoSecurity
Copy link
Collaborator

I think the clippy warnings have become more strict so we were getting compile errors.

@YamatoSecurity
Copy link
Collaborator Author

@fukusuket Do you know why the code coverage is failing?

@YamatoSecurity
Copy link
Collaborator Author

@fukusuket Looks like this error: rust-lang/rust#133606
I suppose we can just wait a few days until they fix it...

@fukusuket
Copy link
Collaborator

fukusuket commented Nov 29, 2024

@YamatoSecurity
I see..., If the nightly build is not required, would the Actions succeed if we change the following to stable?🤔

rustup install nightly
rustup override set nightly

@YamatoSecurity
Copy link
Collaborator Author

@fukusuket That worked! Thanks! I think I will leave it as stable as nightly will be unreliable. Can you review the rest of this PR?

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

@YamatoSecurity YamatoSecurity merged commit 425050b into main Nov 30, 2024
9 checks passed
@YamatoSecurity YamatoSecurity deleted the update-to-3.0.0-dev-build branch November 30, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants