Jialei gh219 improve consistency check between gpu vs cpu computation for general qp ei #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct_GPU_implementation_to_the_new_qp_EI_interface
…ct_GPU_implementation_to_the_new_qp_EI_interface
… style improved, more doc string to add in the next commit
…led and ran unit tests with no error
…ct_GPU_implementation_to_the_new_qp_EI_interface
…ct_GPU_implementation_to_the_new_qp_EI_interface
…ct_GPU_implementation_to_the_new_qp_EI_interface
…ve_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI Conflicts: moe/optimal_learning/cpp/CMakeLists.txt
…ct_GPU_implementation_to_the_new_qp_EI_interface
… instead of NormalRNG
…I_interface' of github.com:sc932/MOE into jialei_gh219_improve_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI Conflicts: moe/optimal_learning/cpp/gpp_expected_improvement_gpu.cpp moe/optimal_learning/cpp/gpp_expected_improvement_gpu.hpp moe/optimal_learning/cpp/gpu/gpp_cuda_math.cu moe/optimal_learning/cpp/gpu/gpp_cuda_math.hpp
…ve_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI
|
Sorry! I clicked the wrong button :( |
…e_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI
| } | ||
|
|
||
| OptimalLearningCudaException::OptimalLearningCudaException(const CudaError& _err) | ||
| : OptimalLearningException(_err.file_and_line_info, _err.func_info, cudaGetErrorString(_err.err)) {} |
There was a problem hiding this comment.
closing brace goes on its own line
|
mostly documentation and one macro fix. should be done after this! |
…e_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI
|
|
||
| OptimalLearningCudaException::OptimalLearningCudaException(const CudaError& error) | ||
| : OptimalLearningException(error.file_and_line_info, error.func_info, cudaGetErrorString(error.err)) { | ||
| } |
There was a problem hiding this comment.
no leading whitespace before the }
|
two whitespace changes then 🚢 congrats & thanks!! :D |
…e_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI
jialeiwang
added a commit
that referenced
this pull request
Aug 1, 2014
…eck_between_gpu_vs_cpu_computation_for_general_qp_EI Jialei gh219 improve consistency check between gpu vs cpu computation for general qp ei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
********* PEOPLE *************
Primary reviewer: @suntzu86
Reviewers: @sc932 @ypwais @yaoster
********* DESCRIPTION **************
Branch Name: jialei_gh219_improve_consistency_check_between_gpu_vs_cpu_computation_for_general_qp_EI
Ticket(s)/Issue(s): Closes #219
********* TESTING DONE *************
make test-no-tox: total test time 27.40s
cpplint.py to check style