Fix kwarg passing in combined example #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +99,7 @@ def run_example(num_to_sample=20, verbose=True, testapp=None, **kwargs): | |||
| exp.historical_data.to_list_of_sample_points(), # Historical data to inform Gaussian Process | |||
| points_to_evaluate, # We will calculate the mean and variance of the GP at these points | |||
| testapp=testapp, | |||
| **kwargs | |||
There was a problem hiding this comment.
i think this should be mean_var_kwargs
|
fix/ship |
|
might mention the kwarg precedence in the function docstring, up to you shipit |
sc932
added a commit
that referenced
this pull request
Aug 5, 2014
Fix kwarg passing in combined example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
********* PEOPLE *************
Primary reviewer: @suntzu86
Reviewers: @yonromai
********* DESCRIPTION **************
Branch Name: sclark_test_new_pull
Ticket(s)/Issue(s): Closes N/A
This extends #355 by @yonromai and cleans up a few other cases where this could fail. It also extends the docs to make it more clear what is getting passed around.
********* TESTING DONE *************
Extended test.
make test