Add exclude-files and exclude-lines args to scan #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
changed the title
domanchi
approved these changes
Feb 9, 2019
| @@ -78,11 +78,14 @@ def apply_default_plugin_options_to_repos(args): | |||
| This applies default values to the config file, if appropriate. | |||
| """ | |||
| for tracked_repo in args.repo: | |||
| # Issue 17: Not touching exclude_regex in repo metadata | |||
| # Just ignoring it for now and using the exclusion CLI args given when calling `scan` | |||
| # (This can be ignored because this function is only called by `add`) | |||
There was a problem hiding this comment.
Add a TODO for grep-ability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Add exclude-files and exclude-lines args to scan
This assumes Yelp/detect-secrets#127 is merged, so I suppose I have a bump commit still
todo