Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#471] Safely get line_number from PotentialSecret #472

Merged
merged 1 commit into from
Aug 1, 2021
Merged

[#471] Safely get line_number from PotentialSecret #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions detect_secrets/core/secrets_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@ def __iter__(self) -> Generator[Tuple[str, PotentialSecret], None, None]:
for filename in sorted(self.files):
secrets = self[filename]

# NOTE: If line numbers aren't supplied, they will default to 0.
for secret in sorted(secrets, key=lambda x: (x.line_number, x.secret_hash, x.type)):
# NOTE: If line numbers aren't supplied, they are supposed to default to 0.
for secret in sorted(secrets, key=lambda x: (x.get(line_number, 0), x.secret_hash, x.type)):
yield filename, secret

def __bool__(self) -> bool:
Expand Down