Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Remote tracking branches for merge detection cannot handle rebased branches #85

Closed
ymilki opened this issue Aug 18, 2014 · 1 comment
Closed

Comments

@ymilki
Copy link
Member

ymilki commented Aug 18, 2014

If a branch is rebased, the next time merge conflict detection is run on the request, the git fetch will fail to fetch due to non-fastforward.

The fetch should include a + in the refspec. See http://git-scm.com/docs/git-fetch and the second EXAMPLES.

@asottile
Copy link
Contributor

The failure mode of this is a git-error tag

ymilki added a commit that referenced this issue Aug 18, 2014
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this issue Aug 18, 2014
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
@ymilki ymilki mentioned this issue Aug 18, 2014
ymilki added a commit that referenced this issue Aug 18, 2014
 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
ymilki added a commit that referenced this issue Aug 18, 2014
Release 0.3.3

 BUG FIXES

 * Don't run merge detection on merged requests (rschlaikjer, #84, #91)
 * Fetch non-ff branches (rschlaikjer, #85, #90)

 IMPROVEMENTS

 * Manually rerun merge detection (rschlaikjer, #86, #92)

 PERFORMANCE TWEAKS

 * Separate git sha retrieval from git merge conflict detection.
   (rschlaikjer, #82, #83)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants