Travis: don't install PHPUnit when not needed #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
JRF/minor-Travis-improvement
branch
from
45b3a8c
to
c631962
Compare
Have the line to `remove phpunit` underneath the `install` command, makes that it has no effect at the time of the initial install, moving it up fixes this. Also removed the `selfupdate` command in line with the Travis script in other plugins/modules.
felixarntz
added
needs-acceptance
acceptance
and removed
code-review
needs-acceptance
labels
|
Acceptance done, Travis build works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the line to
remove phpunitunderneath theinstallcommand, makes that it has no effect at the time of the initial install, moving it up fixes this.Also removed the
selfupdatecommand in line with the Travis script in other plugins/modules.