Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改进建议:基建模块不宜反过来依赖具体的业务模块的PermissionApi,应抽出接口类(如PermissionFrameworkService),业务模块去实现 #699

Open
liyujiang-gzu opened this issue Nov 18, 2024 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@liyujiang-gzu
Copy link
Contributor

基本信息

  • ruoyi-vue-pro 版本:2.3.0
  • 操作系统:windows
  • 数据库:mysql 8
        <!-- 业务组件 -->
        <!-- TODO 基建模块不宜反过来依赖具体的业务模块的PermissionApi,应抽出接口类(如PermissionFrameworkService),业务模块去实现 -->
        <dependency>
            <groupId>cn.iocoder.boot</groupId>
            <artifactId>yudao-module-system-api</artifactId> <!-- 需要使用它,进行数据权限的获取 -->
            <version>${revision}</version>
        </dependency>
@liyujiang-gzu
Copy link
Contributor Author

例如,把yudao-spring-boot-starter-biz-data-permission依赖的yudao-module-system-api移除,在yudao-spring-boot-starter-biz-data-permission模块中新增PermissionFrameworkService#getDataPermission接口代替依赖的PermissionApi#getDeptDataPermission,yudao-module-system-biz模块去实现PermissionFrameworkService#getDataPermission……

@liyujiang-gzu
Copy link
Contributor Author

yudao-spring-boot-starter-biz-data-permission、yudao-spring-boot-starter-excel、yudao-spring-boot-starter-secrurity、yudao-spring-boot-starter-web依赖的yudao-module-system-api 以及 yudao-spring-boot-starter-web依赖的yudao-module-infra-api都应该都抽取XxxFrameworkService接口

@liyujiang-gzu
Copy link
Contributor Author

@YunaiV 是否认同这个重构?

@YunaiV
Copy link
Owner

YunaiV commented Nov 18, 2024

@YunaiV 是否认同这个重构?

可能会在 yudao-common 加个 service 包,把一些需要的,搞进去。

@YunaiV YunaiV self-assigned this Nov 21, 2024
@YunaiV YunaiV added the question Further information is requested label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants