Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'pos=None' handling consistent #76

Open
greschd opened this issue Mar 18, 2020 · 0 comments
Open

Make 'pos=None' handling consistent #76

greschd opened this issue Mar 18, 2020 · 0 comments

Comments

@greschd
Copy link
Member

greschd commented Mar 18, 2020

Currently, setting pos=None in the constructor will set all positions to the origin. There are few places in the code that rely on this behavior, but also some places where pos is not None is explicitly checked.

We need to decide if pos=None should be possible, and then either remove the pos is None checks or add them where they are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant