add LBFGS optimizer #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete tanh_grad
add tanh_grag
Ikkyu321
reviewed
Aug 24, 2022
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| # | ||
| # new_opt_confs = [] | ||
| # for param_group in self.param_groups: | ||
| # optimizer_conf = train_conf.optimizer_conf.add() |
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| views = [] | ||
| for p in self.parameters: | ||
| if p.grad is None: | ||
| view = flow.tensor(np.zeros(p.numel())) |
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| from typing import Callable, Dict, Iterator, List, Tuple, Union | ||
| from functools import reduce | ||
| from collections import defaultdict, abc as container_abcs | ||
| import numpy as np |
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| import oneflow as flow | ||
| from oneflow.nn.optimizer.optimizer import Optimizer, ParamGroup | ||
| from oneflow.nn.parameter import Parameter | ||
| import functools |
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| limitations under the License. | ||
| """ | ||
| import collections | ||
| import math |
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| import math | ||
| from typing import Callable, Dict, Iterator, List, Tuple, Union | ||
| from functools import reduce | ||
| from collections import defaultdict, abc as container_abcs |
python/oneflow/nn/optimizer/lbfgs.py
Outdated
| """ | ||
| import collections | ||
| import math | ||
| from typing import Callable, Dict, Iterator, List, Tuple, Union |
Ikkyu321
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.