Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some errors; more accurate logs #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some errors; more accurate logs #2

wants to merge 1 commit into from

Conversation

Dan-Albrecht
Copy link

  • Prevent running a build that will fail
  • Don't claim to build something if it is not selected
  • Remove some trailing whitespace

ZakKemble
ZakKemble reviewed Jun 14, 2024
View reviewed changes
Copy link
Owner

@ZakKemble ZakKemble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, so I added a few comments a year ago, but I never clicked submit so they've been stuck pending ever since! The script has changed quite a bit so I don't know how relevant this is anymore...

avr-gcc-build.sh
@@ -88,6 +88,16 @@ OPTS_GDB="

OPTS_LIBC=""

if [ $BUILD_LIBC -eq 1 ] && ([ $FOR_LINUX -ne 1 ] || [ $BUILD_GCC -ne 1 ]); then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if GCC has already been built previously? Might be better to check for the existence of $PREFIX_GCC_LINUX/bin/avr-gcc instead.

avr-gcc-build.sh
exit 1
fi

if [ $BUILD_GCC -eq 1 ] && [ $BUILD_BINUTILS -ne 1 ]; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, what if binutils has already been built? Check for $PREFIX_GCC_LINUX/avr/bin/ld.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakKemble ZakKemble ZakKemble left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dan-Albrecht @ZakKemble