Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Transaction type and message to support the Zcash changes from Bitcoin #13

Closed
dconnolly opened this issue Sep 19, 2019 · 0 comments · Fixed by #105
Closed

Update Transaction type and message to support the Zcash changes from Bitcoin #13

dconnolly opened this issue Sep 19, 2019 · 0 comments · Fixed by #105
Assignees
@dconnolly

Comments

@dconnolly
Copy link
Contributor

image
https://zips.z.cash/protocol/protocol.pdf
This was referenced Sep 24, 2019
Closed
Closed
@dconnolly dconnolly self-assigned this Oct 9, 2019
@hdevalence hdevalence mentioned this issue Nov 18, 2019
Merged
@hdevalence hdevalence mentioned this issue Feb 13, 2020
Closed
@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
dconnolly pushed a commit that referenced this issue Mar 13, 2023
@arya2 @dconnolly
Test size constraints on version user agent, reject command, and reje…
e7f3e70 
…ct reason (#13)
mergify bot pushed a commit that referenced this issue Mar 13, 2023
@dconnolly @teor2345 @arya2
Halborn 2023 02 20 (#6297)
47cf0f4 
* Limit version user agents to 256 bytes, rather than 2MB, needs failure tests

* Limit all inv messages to 50,000 entries, existing tests cover this

* Limit reject message strings based on network protocol, needs success and failure tests

* Catch up as fast as possible if inventory rotation is delayed, existing tests cover this

* Truncate inv channel hashes to 1000, needs success and failure tests

* Limit inv registry size to 4 MB, needs over-limit tests for inv and addr

* Test size constraints on version user agent, reject command, and reject reason (#13)

* Test inventory registry memory limits for hashes and peers (#14)

Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>

---------

Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Arya <aryasolhi@gmail.com>
skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
@skyl
Creator detail beautiful next steps (ZcashFoundation#13)
3355dcd 
## What

Make the creator detail beautiful

## Why

People will be proud to share and it will be a good place to learn about
someone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Transaction definition. ZcashFoundation/zebra
1 participant
@dconnolly