Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprout note encryption/decryption implementation. #181

Closed
hdevalence opened this issue Jan 16, 2020 · 4 comments
Closed

Sprout note encryption/decryption implementation. #181

hdevalence opened this issue Jan 16, 2020 · 4 comments
Labels
A-cryptography Area: Cryptography related C-design Category: Software design work NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter)

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Jan 16, 2020

We need an implementation of note encryption. This has possible overlap with librustzcash.

image

https://zips.z.cash/protocol/protocol.pdf#sproutencrypt
https://zips.z.cash/protocol/protocol.pdf#sproutdecrypt

@dconnolly
Copy link
Contributor

dconnolly commented Feb 13, 2020

Two levels of completion:

All the types to represent in the transaction

Some types:

  • sprout::Note (plaintext)
  • sprout::OutCiphertext
  • sprout::EncryptedCiphertext

And implementing methods to do the note encryption

  • NoteEncryptionBuilder

But first:

Related: #266

@dconnolly dconnolly linked a pull request Feb 22, 2020 that will close this issue
@dconnolly dconnolly removed a link to a pull request Feb 22, 2020
@dconnolly dconnolly changed the title Note encryption implementation. Sprout note encryption implementation. Feb 25, 2020
@dconnolly dconnolly changed the title Sprout note encryption implementation. Sprout note encryption/decryption implementation. Feb 25, 2020
@dconnolly dconnolly added the NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) label Apr 2, 2020
@dconnolly dconnolly removed this from the Validate transactions. milestone Jul 2, 2020
@teor2345
Copy link
Contributor

@dconnolly does this belong in the "Transaction Validation" milestone, or the "Wallet Support" milestone?

@dconnolly
Copy link
Contributor

Wallet support

@dconnolly dconnolly added this to the Wallet Support 💰 milestone Oct 1, 2020
@mpguerra mpguerra removed this from the Wallet Support 💰 milestone Jan 5, 2021
@dconnolly dconnolly mentioned this issue Mar 5, 2021
53 tasks
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@conradoplg conradoplg added the A-cryptography Area: Cryptography related label Jun 1, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@teor2345
Copy link
Contributor

We're not planning to do full-node wallet work any time soon.

If we do, we'll need to decide if this ticket is in scope, and update its content, because the spec has changed since it was created.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
Repository owner moved this from 🆕 New to ✅ Done in Zebra Sep 29, 2022
@mpguerra mpguerra moved this from ✅ Done to 🛑 Won't Fix in Zebra Nov 9, 2022
skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cryptography Area: Cryptography related C-design Category: Software design work NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter)
Projects
Archived in project
Development

No branches or pull requests

5 participants