Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on a re-export policy for zebra-chain #201

Closed
hdevalence opened this issue Jan 24, 2020 · 2 comments
Closed

Decide on a re-export policy for zebra-chain #201

hdevalence opened this issue Jan 24, 2020 · 2 comments
Assignees
Labels
C-design Category: Software design work

Comments

@hdevalence
Copy link
Contributor

In #199 I introduced an inconsistency; zebra-chain reëxports redjubjub but not ed25519-zebra. This is a pretty minor issue (just where stuff should go in the tree and how) but it would be good to have a consistent answer to the question of "when should zebra-chain reëxport dependencies".

One possible answer would be to do it only for crates developed by the ZF that are supposed to be part of zebra-chain, but are actually separate crates in order to allow reuse by zcashd or librustzcash. This would include both redjubjub and ed25519-zebra as well as a standalone crate for note encryption (#181).

Another answer would be to reëxport any crate or type which appears in public API for zebra-chain.

@hdevalence hdevalence added Poll::Ready C-design Category: Software design work labels Jan 24, 2020
@dconnolly
Copy link
Contributor

We're going to leave this open for a little while longer to see our dependencies and crates shake out.

@dconnolly
Copy link
Contributor

"If it's part of your api, you should export it." So we need to export ed25519-zebra. #405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-design Category: Software design work
Projects
None yet
Development

No branches or pull requests

2 participants