Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchard: derive OutgoingCipherKey ( Sapling and Orchard) #2041

Closed
dconnolly opened this issue Apr 20, 2021 · 4 comments · Fixed by #5476
Closed

Orchard: derive OutgoingCipherKey ( Sapling and Orchard) #2041

dconnolly opened this issue Apr 20, 2021 · 4 comments · Fixed by #5476
Assignees
@conradoplg
Labels
A-cryptography Area: Cryptography related A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks

Comments

@dconnolly
Copy link
Contributor

Stub:

//     From<(
//         OutgoingViewingKey,
//         ValueCommitment,
//         NoteCommitment,
//         EphemeralKey,
//     )> for OutgoingCipherKey
// {
//     type Error = &'static str;

//     fn from((): ()) -> Result<Self, Self::Error> {
//         Self(prf_ock())
//     }
// }
@dconnolly dconnolly added A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks labels Apr 20, 2021
@dconnolly dconnolly self-assigned this Apr 20, 2021
@dconnolly dconnolly mentioned this issue Apr 20, 2021
Closed
53 tasks
@mpguerra mpguerra added S-needs-triage Status: A bug report needs triage and removed S-needs-triage Status: A bug report needs triage labels May 4, 2021
@mpguerra mpguerra modified the milestone: 2021 Sprint 12 May 10, 2021
@mpguerra
Copy link
Contributor

iiuc this is only for sending notes and therefore will only be relevant when we're implementing wallet support.

I'm removing from the "NU5 Tracking: The Spec"/#1856 Epic until I hear otherwise

@dconnolly dconnolly mentioned this issue Jun 21, 2021
Closed
@mpguerra mpguerra added this to the 2021 Sprint 22 milestone Oct 15, 2021
@mpguerra mpguerra assigned conradoplg and unassigned dconnolly Oct 15, 2021
@dconnolly
Copy link
Contributor Author

#2362 (comment)

@dconnolly
Copy link
Contributor Author

Maybe a dupe of #2362

@mpguerra mpguerra removed this from the 2021 Sprint 22 milestone Oct 18, 2021
@mpguerra mpguerra added this to the 2021 Sprint 22 milestone Nov 2, 2021
@mpguerra mpguerra modified the milestone: 2021 Sprint 22 Nov 2, 2021
@mpguerra mpguerra mentioned this issue Nov 2, 2021
Closed
@teor2345 teor2345 removed this from the 2021 Sprint 22 milestone Nov 8, 2021
@dconnolly dconnolly changed the title Orchard: derive OutgoingCipherKey Orchard: derive OutgoingCipherKey ( Sapling and Orchard) May 26, 2022
@conradoplg conradoplg added the A-cryptography Area: Cryptography related label Jun 1, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@teor2345
Copy link
Contributor

We're not planning to do full-node wallet work any time soon.

If we do, we'll need to decide if this ticket is in scope, and update its content, because the spec has changed since it was created.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
Repository owner moved this from 🆕 New to ✅ Done in Zebra Sep 28, 2022
@teor2345 teor2345 mentioned this issue Oct 25, 2022
Merged
5 tasks
@mergify mergify bot closed this as completed in #5476 Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
A-cryptography Area: Cryptography related A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup(cryptography): Remove unused shielded key and address code ZcashFoundation/zebra
4 participants
@conradoplg @dconnolly @mpguerra @teor2345