Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement transaction binding signature verification key #318

Closed
dconnolly opened this issue Mar 25, 2020 · 3 comments
Closed

Implement transaction binding signature verification key #318

dconnolly opened this issue Mar 25, 2020 · 3 comments
Assignees
@dconnolly
Labels
A-consensus Area: Consensus rule updates

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Mar 25, 2020 •
edited
Loading

image

https://zips.z.cash/protocol/protocol.pdf#saplingbalance

Resolved in https://github.com/ZcashFoundation/zebra/blob/cfc339e8ea558f0f5cd4cb117160ab3f2c542ce0/zebra-consensus/src/transaction.rs
@dconnolly dconnolly added Poll::Pending A-consensus Area: Consensus rule updates labels Mar 25, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone Mar 25, 2020
@hdevalence hdevalence mentioned this issue Mar 25, 2020
Closed
@hdevalence
Copy link
Contributor

There's an interaction to think through with the redjubjub API, since the procedure for creating the binding signature keypair involves manually constructing some scalars and group elements, but the redjubjub API doesn't expose those details.

@hdevalence
Copy link
Contributor

We will not perform the recommended check for implementation faults, since it's impossible to implement without violating encapsulation of the Redjubjub interface.

@daira
Copy link
Contributor

daira commented Aug 6, 2020 •
edited
Loading

I'm surprised by that. You need to be able to compute bsk anyway; DerivePublic and checking equality of public keys are part of the intended public interface.

@hdevalence hdevalence added S-blocked Status: Blocked on other tasks and removed Poll::Pending labels Aug 17, 2020
@mpguerra mpguerra removed this from the Wallet Support 💰 milestone Jan 5, 2021
@teor2345 teor2345 removed the S-blocked Status: Blocked on other tasks label Jan 5, 2021
@dconnolly dconnolly self-assigned this Jan 21, 2021
@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
@birdify @skyl
Adds hover state to carousels (ZcashFoundation#318)
c6f8193 
This adds a nice hover state to carousels so they darken when you hover
over them.

<img width="982" alt="Screen Shot 2024-07-20 at 10 47 18 AM"
src="https://github.com/user-attachments/assets/50f9039a-b81c-4949-828b-0651566b0a70">

---------

Co-authored-by: Skylar Saveland <skylar.saveland@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
A-consensus Area: Consensus rule updates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hdevalence @dconnolly @daira @mpguerra @teor2345