Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Transaction definition. #105

Merged
merged 16 commits into from
Dec 5, 2019
Merged

Update Transaction definition. #105

merged 16 commits into from
Dec 5, 2019

Commits on Nov 27, 2019

  1. Added a few more top-level fields for the Transaction struct

    @dconnolly @hdevalence
    dconnolly authored and hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    0281de0 View commit details
    Browse the repository at this point in the history

  2. Add a placeholder Script type. 

    This could alternately use bytes::Bytes to save some allocations
but I don't think this is important to get perfectly now.  In the future, we
will want to have all of the script handling code in the zebra-script crate,
but we will need to have a container type for an encoded script in zebra-chain,
because otherwise zebra-chain would depend on zebra-script and not the other
way around.
    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    f8ba3de View commit details
    Browse the repository at this point in the history

  3. Rename Transaction{Input,Output} -> Transparent{Input,Output}. 

    These are only *transparent* inputs and outputs, so by putting Transparent in
the name (instead of Transaction) it's more clear that a transaction's inputs
or outputs can also be shielded.
    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    c0fbbfc View commit details
    Browse the repository at this point in the history

  4. Add a LockTime enum.

    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    a8092bf View commit details
    Browse the repository at this point in the history

  5. First attempt at a Transaction enum. 

    This attempts to map the versioning and field presence rules into an ADT, so
that structurally invalid transactions (e.g., a BCTV14 proof in a Sapling
transaction) are unrepresentable.
    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    56b061a View commit details
    Browse the repository at this point in the history

  6. Update zebra-chain/src/transaction.rs 

    Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
    @hdevalence @daira
    hdevalence and daira committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    69e86d6 View commit details
    Browse the repository at this point in the history

  7. Add fixme note on type refinement.

    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    8155de9 View commit details
    Browse the repository at this point in the history

  8. Rename Transaction variants according to version.

    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    f01b75d View commit details
    Browse the repository at this point in the history

  9. Split transaction.rs into submodules.

    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    159d17d View commit details
    Browse the repository at this point in the history

  10. Start filling in spend, output descriptions.

    @hdevalence
    hdevalence committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    bd7b718 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Progress on JoinSplit data structures. 

    This has a lot of duplication and should really use generics to abstract over
Sprout-on-BCTV14 or Sprout-on-Groth16.
    @hdevalence
    hdevalence committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    a712806 View commit details
    Browse the repository at this point in the history

  2. Add data types for Bctv14 and Groth16 proofs. 

    This also adds a trait to abstract over them.
    @hdevalence
    hdevalence committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    2f3a7a0 View commit details
    Browse the repository at this point in the history

  3. Make JoinSplit descriptions generic over the proof system.

    @hdevalence
    hdevalence committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    6950237 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. Update zebra-chain/src/transaction/joinsplit.rs

    @hdevalence
    hdevalence authored Dec 5, 2019
    Configuration menu
    Copy the full SHA
    76c6466 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tx 

    This moves the TransactionHash changes along with the moved TransactionHash code.
    @hdevalence
    hdevalence committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    d34f8a5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'tx' of github.com:ZcashFoundation/zebra2 into tx

    @hdevalence
    hdevalence committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    abce604 View commit details
    Browse the repository at this point in the history