Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse displayed endianness of transaction and block hashes #1171

Merged
merged 8 commits into from
Oct 21, 2020

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Oct 16, 2020

Replaces #1056

  • Cherry picked commit from @vramana where the hard work was done, hope this is ok.
  • Fixed the test cases where it was failing.
  • Fixed zebra-checkpoints binary.

Todo:

  • Get a new checkpoint list for mainnet and testnet. This will be done by @teor2345. I think we can just push the list once done into this PR.

Should close #1031 when/if merged.

yaahc
yaahc previously approved these changes Oct 16, 2020
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge this PR yet - I still need to rebuild the full checkpoint lists.

This change also adds additional checkpoints to the end of each list.
teor2345
teor2345 previously approved these changes Oct 19, 2020
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebuilt the checkpoint lists in commit 544c572.

@teor2345 teor2345 requested a review from yaahc October 19, 2020 02:18
@teor2345
Copy link
Contributor

@oxarbitrage @yaahc I also found a few more places that needed updates:

@teor2345
Copy link
Contributor

I also checked the list of tasks in #1031, and I'm running zebrad start on mainnet and testnet.

@teor2345
Copy link
Contributor

I tried to test this change using zebrad start, but bugs in the sync, state, and network code prevented a full sync. See #1181, #1182, and #1183.

I still think we should merge this change, it's a low-risk improvement, and the bugs aren't likely to be related to this change.

@teor2345 teor2345 requested a review from a team October 21, 2020 00:06
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did not test yet.

@teor2345 teor2345 merged commit 21ad6ff into ZcashFoundation:main Oct 21, 2020
@vramana
Copy link
Contributor

vramana commented Oct 26, 2020

@oxarbitrage Thanks for picking up the PR. I was on vacation and couldn't find the time to finish the PR.

teor2345 added a commit to teor2345/zebra that referenced this pull request Nov 10, 2020
@teor2345 teor2345 mentioned this pull request Nov 10, 2020
6 tasks
teor2345 added a commit to teor2345/zebra that referenced this pull request Nov 12, 2020
teor2345 added a commit that referenced this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse displayed endianness of transaction and block hashes.
5 participants