-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse displayed endianness of transaction and block hashes #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't merge this PR yet - I still need to rebuild the full checkpoint lists.
This change also adds additional checkpoints to the end of each list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebuilt the checkpoint lists in commit 544c572.
This change should have been made in ZcashFoundation#905, but we missed Debug impls and some docs.
@oxarbitrage @yaahc I also found a few more places that needed updates:
|
I also checked the list of tasks in #1031, and I'm running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but did not test yet.
@oxarbitrage Thanks for picking up the PR. I was on vacation and couldn't find the time to finish the PR. |
Replaces #1056
Todo:
Should close #1031 when/if merged.