Transaction proptests etc #118

dconnolly · 2019-11-26T23:52:21Z

Some in -chain, some in -network, for small simple struct impls.

zebra-network/src/protocol/external/types.rs

hdevalence · 2019-12-19T20:27:07Z

This is supposed to address #27, correct?

Relates to #150

zebra-chain/src/proofs/bctv14.rs

zebra-chain/src/transaction/joinsplit.rs

zebra-chain/src/transaction/serialize.rs

zebra-chain/src/transaction/shielded_data.rs

zebra-chain/src/transaction/tests.rs

zebra-chain/src/types.rs

zebra-network/src/protocol/internal/response.rs

hdevalence

Yay! This is awesome. The only substantive comment is the one about Utc::now(), all the others are TIOLI.

…of note encryption work Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>

Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>

…ote encryption work Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>

Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>

dconnolly · 2020-01-28T08:44:46Z

Pertains to #150

This was referenced Nov 27, 2019

Clean module layouts and imports. #37

Closed

Rearrange zebra-network submodules. #119

Merged

dconnolly force-pushed the proptest branch from 01de5ea to 26b5593 Compare December 10, 2019 21:45

dconnolly added this to the Sync and validate zcash mainnet with zebrad milestone Dec 12, 2019

dconnolly force-pushed the proptest branch from 26b5593 to 201c49d Compare December 16, 2019 21:23

dconnolly commented Dec 16, 2019

View reviewed changes

zebra-network/src/protocol/external/types.rs Show resolved Hide resolved

dconnolly changed the title ~~Protocol proptests~~ Small proptests Dec 20, 2019

dconnolly force-pushed the proptest branch from 560dc60 to e7b91e3 Compare December 31, 2019 19:11

dconnolly force-pushed the proptest branch from 7075d90 to 1951574 Compare January 20, 2020 18:23

dconnolly changed the title ~~Small proptests~~ Transaction proptests etc Jan 21, 2020

hdevalence mentioned this pull request Jan 24, 2020

Refine Ed25519 byte arrays to ed25519-zebra types. #199

Merged

dconnolly force-pushed the proptest branch from e41de9e to dd00e75 Compare January 25, 2020 00:42

dconnolly added 17 commits January 27, 2020 18:09

Fix proptest-regressions locations after reorganizations of files

0cf7914

Add a little proptest around Magic's Debug impl

9a35cbb

Add proptest regressions file

d4672af

Add roundtrip proptest for LockTime serialization/deserialization

97637c7

Relates to #150

Truncate LockTime::Time datetimes to only seconds for proptests

3934c97

Add zcash_[de]serialize roundtrip proptest for Script type

053a35e

Add proptest-regressions for transaction/tests.rs

4fd3362

Stubbing out an Arbitrary impl for variant V1 of the Transaction enum

4256143

Transaction::V1 round trip proptest

d761fe4

Remove commented out extra Arbitrary impl for Locktime

5bd65c1

Impl Arbitrary for Bctv14Proof

f0dc374

Add joinsplit::EncryptedCiphertext and derive(Arbitrary) on JoinSplit*

97225ce

Add shielded_data::EncryptedCiphertext

2b5908f

Update (de)serialization to use EncryptedCiphertext types

a54b659

Proptest v1 and v2 transaction variants

6a1f04d

cargo fmt

a64cdea

derive Arbitrary on BlockHeight

3ec91d7

dconnolly requested a review from hdevalence January 28, 2020 04:49

dconnolly modified the milestones: Sync and validate zcash mainnet with zebrad, Validate transactions. Jan 28, 2020