Re-enable post-Sapling mainnet sync tests #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we're at database format version 4 right now? |
teor2345
reviewed
Dec 16, 2020
teor2345
reviewed
Dec 16, 2020
You're right! 👀 |
|
(The macOS failure is a GitHub PR git ref error.) |
teor2345
changed the title
This was referenced Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We disabled our post-Sapling stateful sync tests when the state format changed and required a re-caching of state.
Solution
This re-enables the mainnet test with the newly synced v4 state disk, when testnet is also re-synced I'll enable that in another PR.
Review
Not urgent, will test with a manual trigger of the 'Test' workflow.
Related Issues
Follow Up Work
Re-enable the testnet variant when the re-sync disk is ready. @dconnolly