Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some unit tests and proptests #212

Merged
merged 26 commits into from
Feb 4, 2020
Merged

Some unit tests and proptests #212

merged 26 commits into from
Feb 4, 2020

Conversation

dconnolly
Copy link
Contributor

@dconnolly dconnolly commented Jan 31, 2020 •
edited
Loading

Lots of little tests for things that aren't being exercised yet including proptests for Blocks, BlockHeaders, and BlockHeaderHashes and some other subtypes.

@dconnolly dconnolly marked this pull request as ready for review February 1, 2020 02:03
@dconnolly dconnolly changed the title Some unit tests Some unit tests and proptests Feb 1, 2020
@dconnolly dconnolly requested a review from hdevalence February 1, 2020 05:44
hdevalence
hdevalence reviewed Feb 3, 2020
View reviewed changes
zebra-chain/src/block.rs Outdated Show resolved Hide resolved
hdevalence
hdevalence approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good mod the constant fields in the serialization impls!

@dconnolly
Add a roundtrip (de)serialization proptest for EquihashSolution
b19b808
@dconnolly
derive(Arbitrary) on MerkleTreeRootHash
705c5cf
@dconnolly
derive(Copy) on SaplingNoteTreeRootHash
ac95921
@dconnolly
Use updated EquihashSolution in BlockHeader
c2c695f
@dconnolly
Impl Zcash(De)Serialization for Block
a8df66d
@dconnolly
Extend blockheaderhash unit test to check a single (de)serialization …
93e1bb9 
…case roundtrip
@dconnolly
Update .gitignore
54424fd
@dconnolly
Remove derive(Arbitrary) on BlockHeader
5c40688
@dconnolly
Move block type tests and proptest support impls to block::tests
393f675
@dconnolly
Add proptests-regressions/block/tests.txt
2a27a58
@dconnolly
Cleanup
2e206fa
@dconnolly
Remove debugging variable assignments
ebfee99
@dconnolly
Use Result::expect() in test (de)serializations
836329b
@dconnolly
Add a simple test to check that our mainnet blockheader test vector d…
5a4c52a 
…eserializes without error
@dconnolly
Read and write the block header version, which is fixed at 4
fefa057
@dconnolly
Add comment around sha256d_flush test
1c3c875
@dconnolly
Write and read the equihash solution compactsize on (de)serialize
ecd5c29
@dconnolly
Update test block header hash
f659e60
This was referenced Feb 4, 2020
Closed
Closed
@dconnolly dconnolly merged commit b860461 into main Feb 4, 2020
@dconnolly dconnolly deleted the test-coverage branch February 4, 2020 23:04
@hdevalence hdevalence mentioned this pull request Feb 13, 2020
Closed
@dconnolly dconnolly mentioned this pull request Mar 5, 2021
Closed
53 tasks
skyl added a commit to skyl/zebra that referenced this pull request Sep 25, 2024
@skyl
AI Social sharing and forking 👀 (ZcashFoundation#212)
393a236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence hdevalence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Block Validation
Development

Successfully merging this pull request may close these issues.
2 participants
@dconnolly @hdevalence