-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cartesian_wrench controller to default_controllers.yaml #23
base: indigo-devel
Are you sure you want to change the base?
Add cartesian_wrench controller to default_controllers.yaml #23
Conversation
Have you tested this? Some controllers exist in the source, but haven't really ever been tested (which is why there weren't included). We debugged the Twist controller two summers ago with an intern, but I don't recall ever actually testing the wrench controller after porting it into robot_controllers. |
I used In this link, I attach the movie in which our This is the source code which is used in the movie.
However, I am not sure whether this is the desired motion. |
@erelson perhaps you & @aparker-fetch would want to test/review this before we accept/merge it? |
@708yamaguchi we still haven't gotten around to testing this sorry. We're preparing to announce the upgrade process to Melodic, and things are currently in ros-shadow-fixed but they're not ready for use yet... (ros/rosdistro#20397 we're still finding small issues) |
@708yamaguchi sorry this didn't get into Indigo before the Indigo End of Life date. Do you plan to move to Melodic? |
For the time being, our Fetch robot continues to be indigo. I am sorry, but I will not be able to test this Pull Request on melodic. |
@708yamaguchi okay no problem. I’ll put it on our backlog. |
I added
cartesian_wrench
controller todefault_controllers.yaml
, because it is not listed in the yaml file.The source code of
cartesian_wrench
controller exists in https://github.com/fetchrobotics/robot_controllers/blob/indigo-devel/robot_controllers/src/cartesian_wrench.cpp