Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The outputs.total_comments > 0 trick fails when comments already posted #45

Closed
bwrsandman opened this issue Jul 10, 2022 · 0 comments · Fixed by #46
Closed

The outputs.total_comments > 0 trick fails when comments already posted #45

bwrsandman opened this issue Jul 10, 2022 · 0 comments · Fixed by #46

Comments

@bwrsandman
Copy link
Contributor

When a job says the following, total_comments ends up not triggering the fail:

Removing already posted or extra comments
Everything already posted!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set output total_comments to number of comments before culling ZedThree/clang-tidy-review
1 participant
@bwrsandman