Suggest fixits #16
Merged
Suggest fixits #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use absolute paths in offset lookup dict - fix off-by-one errors in converting offsets <=> line numbers - use correct bit of dictionary - add some debug output
|
This works, but there's still some hard-to-use bits that need ironing out. If a line needs changing in multiple places, it currently comes out as separate suggestions:
which github won't let you apply in a single commit (easily). So I need to work out how to squash them into a single suggestion |
|
Almost complete, now need to handle the "Notes" attributes, which can appear when expanding a macro for instance |
* master: Add `config_file` and `cmake_command` to README Group some log messages Make sure compilers, cmake, make, etc are in the image Flush some info messages Strip enclosing quotes from passed arguments Less quoting in yaml Try using review.py directly as entrypoint Try more quoting of cmake-command Quote cmake-command Add `cmake_command` argument to run CMake as part of Action Add `config_file` argument to use `.clang-tidy` config file Add `--dry-run` argument for local testing Add clang-tidy-12 as an option Add some timing information #20 author revisions #20 - Fix path replace problem Update README.md Update Dockerfile, scripts to allow clang-tidy-11 from focal
* master: Add some instructions for how to set `base_dir` in README Fix trying to serialise pathlib.Path Strip quotes from cmake command before checking if it's empty Add `base_dir` argument to more accurately fix absolute paths
ZedThree
force-pushed
the
suggest-fixits
branch
from
5662b90 to
76cce86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Uses the
--export-fixesargument to read in a yaml file of fixes, which are more easily turned into github suggestions.