Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read from GITHUB_API_URL to work on GHES as well #65

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Read from GITHUB_API_URL to work on GHES as well #65

merged 1 commit into from
Mar 16, 2023

Conversation

rajbos
Copy link
Contributor

@rajbos rajbos commented Mar 2, 2023

I tried something to fix #64 (not a Python expert here), I hope this works and is sufficient 🤗 .

ZedThree
ZedThree approved these changes Mar 16, 2023
View reviewed changes
Copy link
Owner

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks @rajbos !
One minor comment, I would probably set api_url as an attribute in __init__ so that it's only read once, but this is only used a couple of places, so it's absolutely fine.

@ZedThree ZedThree merged commit d7e0d75 into ZedThree:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardcoded GitHub API url doesn't work on GitHub Enterprise Server
2 participants
@rajbos @ZedThree