Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing of sg, sh, g_n and g_h not necessary #8

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jhasse
Copy link
Contributor

@jhasse jhasse commented Jul 29, 2013

I'm not 100% sure, but isn't the hashing of sg, sh, g_h and g_h redundant since they are also part of *params?

I've also added const to some values in the proof (makes it a little bit clearer IMHO).

I also noticed that

bool result = false;

isn't needed and it's possible to directly return with the result.

@imichaelmiers
Copy link
Member

This looks about right. We have a paper deadline on the 5th so until then I don't want to mess with it, least it turn out it was something critical. Thanks

@jhasse
Copy link
Contributor Author

jhasse commented Aug 6, 2013

Any news about the paper? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants