Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and Updates #40

Open
wants to merge 2 commits into
base: swift-4
Choose a base branch
from
Open

Refactoring and Updates #40

wants to merge 2 commits into from

Conversation

robertjpayne
Copy link
Member

This implements several discussed changes to Venice:

  1. Bundles libdill directly, this avoids the need to use an apt/brew package
  2. Adds coroutine local storage support
  3. Refactors coroutines so they manage their own lifetime and clean up automatically

@codecov
Copy link

codecov bot commented Aug 28, 2017

Codecov Report

Merging #40 into swift-4 will decrease coverage by 19.4%.
The diff coverage is 54.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           swift-4     #40       +/-   ##
===========================================
- Coverage       91%   71.6%   -19.41%     
===========================================
  Files            5       5               
  Lines          456     479       +23     
  Branches        22      23        +1     
===========================================
- Hits           415     343       -72     
- Misses          41     136       +95
Impacted Files Coverage Δ
Sources/Venice/FileDescriptor.swift 89.84% <ø> (-1.7%) ⬇️
Sources/Venice/Error.swift 70% <100%> (-5%) ⬇️
Sources/Venice/Coroutine.swift 43.11% <43.35%> (-49%) ⬇️
Sources/Venice/Channel.swift 81.51% <82.45%> (-8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb3bb6...2b183e0. Read the comment docs.

@paulofaria
Copy link
Member

The drop in coverage is because of libdill? Let me see if we can ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants