ZCS-4586 update AccountInfo Model and the AccountRepository with Lice… #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naijenn
requested review from
chinmay15,
desouzas,
piyush4360,
rupalid,
shrikant-prasad and
swapnilpingle89
desouzas
reviewed
Sep 28, 2018
src/java/com/zimbra/graphql/repositories/impl/ZXMLAccountRepository.java
Outdated
Show resolved
Hide resolved
| final AccountSelector selector = new AccountSelector(AccountBy.id, zsc.getAuthToken().getAccountId()); | ||
| final GetAccountInfoRequest accountInfoRequest = new GetAccountInfoRequest(selector); | ||
| final GetInfoRequest request = new GetInfoRequest(); | ||
| final Element accountResponse = XMLDocumentUtilities.executeDocument( |
There was a problem hiding this comment.
This works for now.
We may consider determining if the communityUrl is requested before doing the entire getAccountInfo request just for that. Or, perhaps adding it to getInfo and deprecating the other since it is seemingly the only thing missing?
chinmay15
changed the title
chinmay15
suggested changes
Oct 3, 2018
|
Chinmay, thanks for bringing this up. I believe the other ticket in the sprint was to build out the getInfoRequest. I brought this issue up, and it was implied that there was a request for adding the licenseInfo in the AccountInfo as well. |
chinmay15
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graphQL query accountInfoGet now includes LicenseInfo details from the LicenseInfo Class.