Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Set tutorial output more informative #583

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Set tutorial output more informative #583

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e7b85
Set tutorial output more informative
Harirai Oct 3, 2020
092f218
Fixed tutorial test and imporved output
Harirai Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cmd/tutorial.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (o tutorialCmd) runStdin() CommandRunnerFunc {
return err
}

prompt.Success("Set tutorial successful!")
prompt.Success("Set tutorial " + obj.Tutorial + " successful!")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what you think about

prompt.Success("Tutorial " + response + "d")

for me it's a clearer message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure!
I assume you want message to be like "Tutorial enabled" , response already contains "d".
So I think it should be prompt.Success("Tutorial " + response) .
Tell me if I understood it wrong otherwise I'll make the above changes and fix the test soon. 😃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's it @Harirai
keep going


return nil
}
Expand Down Expand Up @@ -96,7 +96,7 @@ func (o tutorialCmd) runPrompt() CommandRunnerFunc {
if err != nil {
return err
}
prompt.Success("Set tutorial successful!")
prompt.Success("Set tutorial " + response + " successful!")
return nil
}
}