Skip to content

Commit

Permalink
Make installer default editor message clear
Browse files Browse the repository at this point in the history
Fixes git-for-windows/git#1872

Signed-off-by: aakriti-jain <aakritijain1102@gmail.com>
  • Loading branch information
aakriti-jain committed Oct 11, 2018
1 parent ffdfbb8 commit 8e46ce4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion installer/install.iss
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,7 @@ begin
// 2nd choice
Top:=TopOfLabels;
CbbEditor.Items.Add('Use Vim (the ubiquitous text editor) as Git'+#39+'s default editor');
CreateItemDescription(EditorPage,'The <A HREF=http://www.vim.org/>Vim editor</A>, while powerful, <A HREF=https://stackoverflow.blog/2017/05/23/stack-overflow-helping-one-million-developers-exit-vim/>can be hard to use</A>. Its user interface is'+#13+'unintuitive and its key bindings are awkward.'+#13+#13+'<RED>Note:</RED> Vim is the default editor of Git for Windows only for historical reasons, and'+#13+'it is highly recommended to switch to a modern GUI editor instead.',Top,Left,LblEditor[GE_VIM],False);
CreateItemDescription(EditorPage,'The <A HREF=http://www.vim.org/>Vim editor</A>, while powerful, <A HREF=https://stackoverflow.blog/2017/05/23/stack-overflow-helping-one-million-developers-exit-vim/>can be hard to use</A>. Its user interface is'+#13+'unintuitive and its key bindings are awkward.'+#13+#13+'<RED>Note:</RED> Vim is the default editor of Git for Windows only for historical reasons, and'+#13+'it is highly recommended to switch to a modern GUI editor instead.'+#13+#13+'<RED>Note:</RED> This will leave the '+#39+'core.editor'+#39+' option unset, which will make Git fall back'+#13+'to the '+#39+'EDITOR'+#39+' environment variable. The default Editor is Vim.',Top,Left,LblEditor[GE_VIM],False);
EditorAvailable[GE_VIM]:=True;
// 3rd choice
Expand Down

0 comments on commit 8e46ce4

Please sign in to comment.