From 4778b53da9e26db966073a0a3123a3aa4acb9337 Mon Sep 17 00:00:00 2001 From: kobewi <kobewi4e@gmail.com> Date: Fri, 15 Sep 2023 01:15:42 +0200 Subject: [PATCH] Don't paste nodes as sibling of scene root --- editor/scene_tree_dock.cpp | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/editor/scene_tree_dock.cpp b/editor/scene_tree_dock.cpp index 29a9b63d2e1..3601f594a70 100644 --- a/editor/scene_tree_dock.cpp +++ b/editor/scene_tree_dock.cpp @@ -2981,7 +2981,10 @@ void SceneTreeDock::_tree_rmb(const Vector2 &p_menu_pos) { menu->add_icon_shortcut(get_editor_theme_icon(SNAME("ActionCopy")), ED_GET_SHORTCUT("scene_tree/copy_node"), TOOL_COPY); if (selection.size() == 1 && !node_clipboard.is_empty()) { menu->add_icon_shortcut(get_editor_theme_icon(SNAME("ActionPaste")), ED_GET_SHORTCUT("scene_tree/paste_node"), TOOL_PASTE); - menu->add_icon_shortcut(get_editor_theme_icon(SNAME("ActionPaste")), ED_GET_SHORTCUT("scene_tree/paste_node_as_sibling"), TOOL_PASTE); + menu->add_icon_shortcut(get_editor_theme_icon(SNAME("ActionPaste")), ED_GET_SHORTCUT("scene_tree/paste_node_as_sibling"), TOOL_PASTE_AS_SIBLING); + if (selection.front()->get() == edited_scene) { + menu->set_item_disabled(-1, true); + } } menu->add_separator(); } @@ -3380,12 +3383,19 @@ List<Node *> SceneTreeDock::paste_nodes(bool p_paste_as_sibling) { } Node *paste_parent = edited_scene; + Node *paste_sibling = nullptr; + List<Node *> selection = editor_selection->get_selected_node_list(); if (selection.size() > 0) { paste_parent = selection.back()->get(); } if (p_paste_as_sibling) { + if (paste_parent == edited_scene) { + return pasted_nodes; // Don't paste as sibling of scene root. + } + + paste_sibling = paste_parent; paste_parent = paste_parent->get_parent(); } @@ -3399,7 +3409,7 @@ List<Node *> SceneTreeDock::paste_nodes(bool p_paste_as_sibling) { EditorUndoRedoManager *ur = EditorUndoRedoManager::get_singleton(); if (paste_parent) { - ur->create_action(vformat(p_paste_as_sibling ? TTR("Paste Node(s) as Sibling of %s") : TTR("Paste Node(s) as Child of %s"), paste_parent->get_name()), UndoRedo::MERGE_DISABLE, edited_scene); + ur->create_action(vformat(p_paste_as_sibling ? TTR("Paste Node(s) as Sibling of %s") : TTR("Paste Node(s) as Child of %s"), paste_sibling ? paste_sibling->get_name() : paste_parent->get_name()), UndoRedo::MERGE_DISABLE, edited_scene); } else { ur->create_action(TTR("Paste Node(s) as Root"), UndoRedo::MERGE_DISABLE, edited_scene); }