#311 impl for defining MappingStyle and SequenceStyle via Annotation #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaubry
force-pushed
the
master
branch
2 times, most recently
from
d4fd04a
to
cb0768c
Compare
|
It has been two years since this fix has been committed, is there a plan to push it in to the master branch? |
|
It's missing tests that show that the feature works as intended. I can't merge this without tests and I don't have time to develop them myself. If someone wants to do it, I'll gladly merge the code. |
Closed
aaubry
force-pushed
the
master
branch
8 times, most recently
from
a0f8359
to
78b1ab3
Compare
|
This PR appears to be abandoned, it's over a year old. I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on implementing #311
Not sure how to add tests for it though...
PS: Merry Christmas :-)