Eliminate allocations from ReflectionUtility.GetImplementedInterfaces #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReflectionUtility.GetImplementedInterfaces
allocated an iterator object for every call to GetImplementedInterfaces. This results in an allocation per object serialized in the benchmark.I refactored the implementation to avoid the iterator by using
Type.FindIterfaces
. In order to ensure there are no captures / allocations in the delegate, I made the lambda static (which necessitates the move to lang version 9).This change saves about 2% of CPU and memory allocations in the benchmark:
Before
After