Removes sealed from a number of classes and respects empty strings in enummember #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n9
reviewed
Sep 26, 2024
| @@ -210,7 +210,7 @@ private void HandleEnum(ITypeSymbol type) | |||
| if (enumMember != null) | |||
| { | |||
| var argument = enumMember.NamedArguments.FirstOrDefault(x => x.Key == "Value"); | |||
| if (!string.IsNullOrWhiteSpace(argument.Value.Value as string)) | |||
| if ((argument.Value.Value as string) != null) | |||
There was a problem hiding this comment.
I actually could have gotten rid of the string check altogether since I’m just checking if it’s null. The value property there is always going to be either null or a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #982
Fixes #983
Fixes #984