Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkgconfig #10

Closed
wants to merge 5 commits into from
Closed

Pkgconfig #10

wants to merge 5 commits into from

Conversation

phodina
Copy link
Contributor

@phodina phodina commented May 14, 2023

Hi,
thanks for an amazing library and LiveCaptions!

This adds the following:

  • package version in CMakeLists.txt (better to have some releases and not just grab commits)
  • template for pkg-config file (so it can be used as dependency)
  • installation target for pkg-config.

I'd like to see LiveCaptions running on Alpine Linux on my "old" phone OnePlus 6 running PostmarketOS.

@phodina
Copy link
Contributor Author

phodina commented May 14, 2023

I'll try to push one more PR for CMake install targets since the files have to be manually installed in the APKBUILD. Also other package managers will benefit from calling just DESTDIR="$pkgdir" cmake --install build

@nekowinston
Copy link
Contributor

It might be worth noting that #9 does some of the same things.

@phodina
Copy link
Contributor Author

phodina commented May 16, 2023

Thanks, yeah looks like it does the same mostly + Nix stuff

@abb128
Copy link
Owner

abb128 commented May 17, 2023

I went ahead and merged the nix flake PR, is any of this still needed?

@phodina
Copy link
Contributor Author

phodina commented May 20, 2023

@abb128 Most of stuff is already there.

The only major missing this is the versioning to keep compatibility through SONAME. Here's how to set the CMAKE variable.

@phodina phodina closed this May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants