Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haven't got a digest in a while #65

Closed
steveoh opened this issue Oct 2, 2018 · 29 comments
Closed

Haven't got a digest in a while #65

steveoh opened this issue Oct 2, 2018 · 29 comments
Labels
bug Something isn't working

Comments

@steveoh
Copy link

steveoh commented Oct 2, 2018

22 days. Did something change? Do I need to modify my config or something? repo is https://github.com/agrc/gis.utah.gov

@brad-decker
Copy link

Confirmed it stopped working for us too.

@abhijeetps
Copy link
Owner

Hi @steveoh , @brad-decker ,
Thanks for opening this issue.
Please have a look at this: https://github.com/search?o=desc&q=Weekly+Digest&s=created&type=Issues

You might be seeing that Weekly Digest is working fine for these repositories.

Is it possible to share the repository where you have installed the application so that I can have a look at it?

Try reinstalling app in your repository once. Also, the configuration is optional. Weekly Digest will work fine without configuring .github/weekly-digest.yml.

If the problem persists, please let me know so that I can trace the bug behind it. Currently, I cannot retrace the bug.

Please suggest some more features that you would like to see in the weekly digest app. 😄

@abhijeetps abhijeetps added the bug Something isn't working label Oct 8, 2018
@steveoh
Copy link
Author

steveoh commented Oct 8, 2018

I left the repo link in my comment. I'll try the uninstall reinstall option

@steveoh
Copy link
Author

steveoh commented Oct 10, 2018

I think my issue is that you changed publish day from an integer to a day abbreviation at some point or that is the only difference i can see right now.

@abhijeetps
Copy link
Owner

@steveoh , Yeah, I saw that you made some changes in that repository: agrc/gis.utah.gov@b389164

And looks like it's working fine now: agrc/gis.utah.gov#962 🎉

I made the app to understand both numeric and alphabetical dates and work properly, but I am not sure what went wrong. I will look again into it. 👀

Sorry for the inconvenience caused. 🙏

@abhijeetps
Copy link
Owner

@brad-decker , maybe you might be facing the same problem, can you once check it out and update if the problem persists.
Thanks. 😄

@steveoh steveoh closed this as completed Oct 10, 2018
@brad-decker
Copy link

So i deleted the install, then reinstalled it. Same issue. I got the initial weekly digest but then sunday came and went without an update. is a config file now required? @abhijeetps

@steveoh
Copy link
Author

steveoh commented Oct 15, 2018

Mine is set to publish monday so if nothing shows up tonight or tomorrow morning, then there is an issue up stream.

@abhijeetps
Copy link
Owner

@brad-decker , Adding weekly-digest.yml for config is an optional feature. It works by default if the configuration is not defined.

@steveoh , I am watching your repository closely, the app should publish weekly digest, if it won't, I will ask the my mentor about the issue.

@abhijeetps
Copy link
Owner

Here's the recent Weekly Digest, being published by app on many repositories (on Sunday), for example: https://github.com/search?o=desc&q=Weekly+Digest&s=created&type=Issues

@maestromac
Copy link

I'm also not getting the weekly update. I receive the first digest and that was it. This is me fiddling around with the setting trying to evoke it. Any tips?

@maestromac
Copy link

re-adding solved it. This bug might have something to do with updating the .yml file.

@steveoh
Copy link
Author

steveoh commented Oct 29, 2018

I haven't got a digest in a while. What was your solution?

@steveoh steveoh reopened this Oct 29, 2018
@maestromac
Copy link

What I did was.

  1. Remove .github/weekly-digest.yml
  2. Remove the Weekly Digest integration
  3. Re-add Weekly Digest integration
  4. Re-add .github/weekly-digest.yml

@steveoh
Copy link
Author

steveoh commented Oct 29, 2018

Ok I just tried your steps. We'll see how my mileage varies.

@steveoh
Copy link
Author

steveoh commented Nov 7, 2018

Still no digest. I don't know how to make this work. What is special about my repo?

@maestromac
Copy link

Mine stop working too ☹️

@abhijeetps
Copy link
Owner

abhijeetps commented Nov 7, 2018

I have opened a discussion here on Slack: https://probot-talk.slack.com/archives/C6S4FC8AF/p1541616078059300
I too can't figure out the reason behind the app not working fine on few repositories. I hope someone from Probot will help me with this.
I will let you know if I receive any updates.

@abhijeetps
Copy link
Owner

Hey, just a minor update on my progress of trying to figure out why the app is not working on some repositories.
I was checking out logs and found the following error:

ERROR event: {"message":"API rate limit exceeded for installation ID XXXXXX.","documentation_url":"https://developer.github.com/v3/#rate-limiting"}
  HttpError: {"message":"API rate limit exceeded for installation ID XXXXXX.","documentation_url":"https://developer.github.com/v3/#rate-limiting"}
      at response.text.then.message (/home/nowuser/src/node_modules/@octokit/rest/lib/request/request.js:72:19)
      at process._tickCallback (internal/process/next_tick.js:68:7)
  
  event: {
    "event": "schedule.repository",
    "installation": XXXXXX,
    "repository": "owner/repository"
  }

I will try to figure out with Probot and GitHub team of how I can work with this problem.
As the popularity of this app is increasing, this app might need more requests in future, and needs a strong solution for the same.

I will keep you updated about this more.
Thank you for using Weekly Digest app. 😄

@steveoh
Copy link
Author

steveoh commented Jan 9, 2019

Any love on this lately?

@yangwenmai
Copy link

talkgo/night#123
After that, I modified the default configuration, but it didn't trigger the build, and then tried to reinstall, but it's still not generated. Because the default value is Sunday, so I need to wait until Sunday to trigger?

@yangwenmai
Copy link

@abhijeetps Please help me when you're not busy.

@yangwenmai
Copy link

@abhijeetps Please help me when you're not busy.

Now, It's work for my repos

@abhijeetps
Copy link
Owner

abhijeetps commented Jan 28, 2019

@yangwenmai , it's really good to see that it works on your repository.
Though, probably you might still face some problem with it as Sunday is a pretty busy day for Weekly Digest app.
I recommend you to add .github/weekly-digest.yml file and configure your app to publish weekly digest on some other day.

@abhijeetps
Copy link
Owner

@steveoh , I know you were among the first users of my Weekly Digest application, and I feel really bad that it's not working on your repo. :(
I have seen that you have even tried changing days but still, it's not working out.
But, one thing that I am pretty sure of is that it not a problem in your end, there's some bug in the app only which is holding it from publishing weekly digests for your repo.
I am trying to find out a bug for the same, but still, I have no clue, what the bug is. I think I will have to try debug the code and spend a day at the logs to check the problem behind it. 😄

@abhijeetps
Copy link
Owner

@steveoh , looks like Weekly Digest app published a Weekly Digest on Monday as you have configured the app to be. Thus, IMO, to sum it up, I think it's probably because it's touching rate limits before and it's unable to publish digests.
agrc/gis.utah.gov#1014
Let's see what happens on next Monday.

@abhijeetps
Copy link
Owner

@maestromac and @brad-decker , is it possible to share your repo name where you have installed Weekly Digest app so that I can have a close look on the problem.
And probably, it looks like it published a digest on @steveoh repository, might have worked on your as well.

@yangwenmai
Copy link

@yangwenmai , it's really good to see that it works on your repository.
Though, probably you might still face some problem with it as Sunday is a pretty busy day for Weekly Digest app.
I recommend you to add .github/weekly-digest.yml file and configure your app to publish weekly digest on some other day.

I set thurday, and i will take a look in that day.

@abhijeetps
Copy link
Owner

Hey @steveoh , sorry for the ping again.
But it looks like the Weekly Digest app has started working fine on your repository again for the second time from my last message.
See: agrc/gis.utah.gov#1020

Since it has started working again normally without any changes done on my end, I think I can say that it was some problem with GitHub APIs.

I will close this issue now.

Also, I have a piece of good news that I would like to share. Week;y Digest now has over 5000 Weekly Digests published by the bot! 🎉

Thank you all for your love and support for my app! ❤️
Also, please feel free to reopen a new issue, if a new bug arrives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants