Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Effect of Economic News on Gold Prices Analysis #638

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

fspzar123
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: The Effect of Economic News on Gold Prices Analysis

  • Info about the related issue (Aim of the project): This project aims to analyze the gold prices based on the news articles in the dataset.
  • Name: Filbert Shawn
  • Email ID for further communication: fspzar123@gmail.com
  • GitHub ID: fspzar123
  • Idenitfy yourself: Student/Open-Source Contributor

Closes: #507

Describe the add-ons or changes you've made 📃

  • No big changes to the original files

Type of change ☑️

What sort of change have you made:

  • Resolved the conflict with the main branch

How Has This Been Tested? ⚙️

'Able to merge. The branches can be automatically merged.' Tested merging in my forked repository

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Jun 7, 2024

Our team will soon review your PR. Thanks @fspzar123 :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the logs folder.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 7, 2024
@fspzar123
Copy link
Contributor Author

I have deleted the logs directory. Please review my PR

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 11, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @fspzar123

@abhisheks008 abhisheks008 merged commit 8f9bde1 into abhisheks008:main Jun 11, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Effect of Economic News on Gold Prices Analysis
2 participants