Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android, build and test documentation #38

Closed
mattheworiordan opened this issue Aug 21, 2015 · 6 comments
Closed

Android, build and test documentation #38

mattheworiordan opened this issue Aug 21, 2015 · 6 comments
Assignees

Comments

@mattheworiordan
Copy link
Member

@paddybyers please can you update the README ASAP for users to:

  • Understand how to use the library with Android
  • Build the JARs
  • Run the test suite, including info relating to the encryption issues we have seen a few times
@mattheworiordan
Copy link
Member Author

Travis needs to build Android and run Android tests, see https://docs.travis-ci.com/user/languages/android

@mattheworiordan mattheworiordan added bug Something isn't working. It's clear that this does need to be fixed. and removed help wanted labels Dec 30, 2015
@gokhanbarisaker
Copy link
Contributor

@mattheworiordan Whether it is Android or pure Java, JUnit tests will run on local JVM. We might run these tests using AndroidJUnitRunner, but they require a connected (virtual or physical) device. For that, Cloud Test Lab would be a better option

@paddybyers
Copy link
Member

Travis needs to build Android and run Android tests

There is no longer a separate Android build of the library.

The android-test subproject is set up to build and run the tests on Android with AndroidJUnitRunner which will work with a locally-connected device or emulator.

Travis needs to build Android and run Android tests, see https://docs.travis-ci.com/user/languages/android

I'm not sure how well that Travis CI support will work for us because it takes over the building of the tests based on things you specify in the .yml instead of using the gradle configuration we provide. But I've not played with it so I don't know how flexible it is.

For that, Cloud Test Lab would be a better option

@gokhanbarisaker if you have experience with that and recommend it, it would be worth trying out.

@mattheworiordan
Copy link
Member Author

For that, Cloud Test Lab would be a better option

Sure, but it is very handy to have one test suite that passes or fails, and I expect if we used Cloud Test Lab we'd need to have a separate job run. If I am wrong, and you can integrate into the Travis CI tests, then please do go ahead, although perhaps we should try Travis first before ruling it out as if it works that should be easiest

@mattheworiordan mattheworiordan added ci issue and removed bug Something isn't working. It's clear that this does need to be fixed. enhancement New feature or improved functionality. labels Oct 16, 2016
@funkyboy
Copy link
Contributor

I am guessing this is no longer an issue when #372 is merged?

@paddybyers
Copy link
Member

I am guessing this is no longer an issue when #372 is merged?

I agree, I think we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants