Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AutoCloseable and try-with-resources to clean up CBCCipher concurrent modification check #747

Closed
QuintinWillison opened this issue Feb 1, 2022 · 3 comments
Closed

Use AutoCloseable and try-with-resources to clean up CBCCipher concurrent modification check #747

QuintinWillison opened this issue Feb 1, 2022 · 3 comments
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Feb 1, 2022 •
edited by sync-by-unito bot
Loading

This requires us to increase our Android API level requirement from 16 to 19, as that's a requirement of using AutoCloseable

┆Issue is synchronized with this Jira Task by Unito
@QuintinWillison QuintinWillison added the code-quality Affects the developer experience when working in our codebase. label Feb 1, 2022
@QuintinWillison
Copy link
Contributor Author

Unblocked by #804.

@QuintinWillison QuintinWillison linked a pull request Jun 22, 2022 that will close this issue
Add finalize() and AutoCloseable support to AblyRest instances #807
Merged
@QuintinWillison QuintinWillison removed a link to a pull request Jun 22, 2022
Add finalize() and AutoCloseable support to AblyRest instances #807
Merged
@QuintinWillison
Copy link
Contributor Author

Oops, sorry for the noise. Wrong issue.

@ttypic
Copy link
Contributor

ttypic commented Sep 29, 2023

We allowed concurrent encryption / decryption in #969

@ttypic ttypic closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuintinWillison @ttypic